Re: [PATCH 2/4] Add replace_page(), change the mapping of pte fromone page into another

[Avi Kivity]

KAMEZAWA Hiroyuki wrote:
> Can I make a question ? (I'm working for memory cgroup.)
>
> Now, we do charge to anonymous page when
>   - charge(+1) when it's mapped firstly (mapcount 0->1)
>   - uncharge(-1) it's fully unmapped (mapcount 1->0) vir page_remove_rmap().
>
> My quesion is
>  - PageKSM pages are not necessary to be tracked by memory cgroup ?
>  - Can we know that "the page is just replaced and we don't necessary to do
>    charge/uncharge".
>  - annonymous page from KSM is worth to be tracked by memory cgroup ?
>    (IOW, it's on LRU and can be swapped-out ?)
>   

My feeling is that shared pages should be accounted as if they were not 
shared; that is, a share page should be accounted for each process that 
shares it.  Perhaps sharing within a cgroup should be counted as 1 page 
for all the ptes pointing to it.


--
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/