Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback fromalloc_large_system_hash

[Catalin Marinas]

On Thu, 2008-12-11 at 09:50 +0000, Catalin Marinas wrote:
> On Wed, 2008-12-10 at 11:04 -0800, Dave Hansen wrote:
> > On Wed, 2008-12-10 at 18:27 +0000, Catalin Marinas wrote:
> > > 
> > > @@ -4570,6 +4571,8 @@ void *__init alloc_large_system_hash(const char *tablename,
> > >         if (_hash_mask)
> > >                 *_hash_mask = (1 << log2qty) - 1;
> > >  
> > > +       memleak_alloc(table, size, 1, GFP_ATOMIC);
> > > +
> > >         return table;
> > >  }
> > 
> > Why is this sucker GFP_ATOMIC?
> 
> It could be GFP_KERNEL, it don't think it really matter at this point.

Actually, for consistency is should be GFP_ATOMIC even if the flag might
not be used. All the other allocations in this function (vmalloc,
__get_free_pages) use GFP_ATOMIC.

-- 
Catalin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/