Re: [PATCH 07/15] kmemleak: Add memleak_alloc callback fromalloc_large_system_hash

From: Dave Hansen
Date: Thu Dec 11 2008 - 12:30:46 EST


On Thu, 2008-12-11 at 09:50 +0000, Catalin Marinas wrote:
> > Since alloc_large_system_hash() is using bootmem (and is called early),
> > I'm a little surprised that it is OK to call into memleak_alloc() which
> > uses kmem_cache_alloc(). Is the slab even set up at this point?
>
> It doesn't need to be. Early callbacks like this are logged by kmemleak
> in a buffer and properly registered once the slab allocator is fully
> initialised (slab initialisation needs to allocate some memory for
> itself as well).

Ahh, thanks for the clarification. Could you add something to the code
to this effect?

-- Dave

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/