Re: [PATCH 1/3] filesystem notification: create fs/notify to contain all fs notification

From: KOSAKI Motohiro
Date: Mon Dec 15 2008 - 20:02:24 EST


Hi

> Creating a generic filesystem notification interface, fsnotify, which will be
> used by inotify, dnotify, and eventually fanotify is really starting to
> clutter the fs directory. This patch simply moves inotify and dnotify into
> fs/notify/inotify and fs/notify/dnotify respectively.
>
> Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
> ---
>
> fs/Kconfig | 39 --
> fs/Makefile | 5
> fs/dnotify.c | 194 --------
> fs/inotify.c | 913 --------------------------------------
> fs/inotify_user.c | 778 --------------------------------
> fs/notify/Kconfig | 2
> fs/notify/Makefile | 2
> fs/notify/dnotify/Kconfig | 10
> fs/notify/dnotify/Makefile | 1
> fs/notify/dnotify/dnotify.c | 194 ++++++++
> fs/notify/inotify/Kconfig | 27 +
> fs/notify/inotify/Makefile | 2
> fs/notify/inotify/inotify.c | 913 ++++++++++++++++++++++++++++++++++++++
> fs/notify/inotify/inotify_user.c | 778 ++++++++++++++++++++++++++++++++
> 14 files changed, 1931 insertions(+), 1927 deletions(-)
> delete mode 100644 fs/dnotify.c
> delete mode 100644 fs/inotify.c
> delete mode 100644 fs/inotify_user.c
> create mode 100644 fs/notify/Kconfig
> create mode 100644 fs/notify/Makefile
> create mode 100644 fs/notify/dnotify/Kconfig
> create mode 100644 fs/notify/dnotify/Makefile
> create mode 100644 fs/notify/dnotify/dnotify.c
> create mode 100644 fs/notify/inotify/Kconfig
> create mode 100644 fs/notify/inotify/Makefile
> create mode 100644 fs/notify/inotify/inotify.c
> create mode 100644 fs/notify/inotify/inotify_user.c

1) this mail only contain Kconfig and Makefile changing patch.
iow, this patch doesn't contain file moving information.
iow, patch statics and actual patch are different.
2) your latter patch doesn't depend on this patch.
this patch doesn't have justification.
I recommend to separate this patch.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/