Re: [PATCH 1/3] filesystem notification: create fs/notify tocontain all fs notification

[Eric Paris]

On Tue, 2008-12-16 at 10:02 +0900, KOSAKI Motohiro wrote:
> Hi
> 
> > Creating a generic filesystem notification interface, fsnotify, which will be
> > used by inotify, dnotify, and eventually fanotify is really starting to
> > clutter the fs directory.  This patch simply moves inotify and dnotify into
> > fs/notify/inotify and fs/notify/dnotify respectively.
> > 
> > Signed-off-by: Eric Paris <eparis@xxxxxxxxxx>
> > ---
> > 
> >  fs/Kconfig                       |   39 --
> >  fs/Makefile                      |    5 
> >  fs/dnotify.c                     |  194 --------
> >  fs/inotify.c                     |  913 --------------------------------------
> >  fs/inotify_user.c                |  778 --------------------------------
> >  fs/notify/Kconfig                |    2 
> >  fs/notify/Makefile               |    2 
> >  fs/notify/dnotify/Kconfig        |   10 
> >  fs/notify/dnotify/Makefile       |    1 
> >  fs/notify/dnotify/dnotify.c      |  194 ++++++++
> >  fs/notify/inotify/Kconfig        |   27 +
> >  fs/notify/inotify/Makefile       |    2 
> >  fs/notify/inotify/inotify.c      |  913 ++++++++++++++++++++++++++++++++++++++
> >  fs/notify/inotify/inotify_user.c |  778 ++++++++++++++++++++++++++++++++
> >  14 files changed, 1931 insertions(+), 1927 deletions(-)
> >  delete mode 100644 fs/dnotify.c
> >  delete mode 100644 fs/inotify.c
> >  delete mode 100644 fs/inotify_user.c
> >  create mode 100644 fs/notify/Kconfig
> >  create mode 100644 fs/notify/Makefile
> >  create mode 100644 fs/notify/dnotify/Kconfig
> >  create mode 100644 fs/notify/dnotify/Makefile
> >  create mode 100644 fs/notify/dnotify/dnotify.c
> >  create mode 100644 fs/notify/inotify/Kconfig
> >  create mode 100644 fs/notify/inotify/Makefile
> >  create mode 100644 fs/notify/inotify/inotify.c
> >  create mode 100644 fs/notify/inotify/inotify_user.c
> 
> 1) this mail only contain Kconfig and Makefile changing patch.
>    iow, this patch doesn't contain file moving information.
>    iow, patch statics and actual patch are different.
> 2) your latter patch doesn't depend on this patch.
>    this patch doesn't have justification.
>    I recommend to separate this patch.

It is there, it is just in the git -M rename diff output rather than
"normal" diff.  See the sections like:

diff --git a/fs/dnotify.c b/fs/notify/dnotify/dnotify.c
similarity index 100%
rename from fs/dnotify.c
rename to fs/notify/dnotify/dnotify.c

This type of patch can be applied directly to your git tree and makes
review trivial.....

If people who will put this into a subsystem would prefer the long diff
I'll gladly resend.

I'll agree it isn't required but the other 2 aren't going to apply
without it, and it does clean up fs.  I'd much rather get this early
than in the middle somewhere since others are also looking at changing
this subsystem at the same time....     It can be dropped it others
agree....

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/