Re: [PATCH] kbuild: warn about headers using __[us]{8,16,32,64} types w/out linux/types.h

From: Sam Ravnborg
Date: Tue Dec 30 2008 - 05:41:38 EST


On Mon, Dec 29, 2008 at 03:27:51PM -0500, Mike Frysinger wrote:
> >
> > We do not need to warn for each line in a file. Only once is enough.
>
> i wasnt sure about that ... got pretty noisy the way i posted it :)
>
> > Also I assume that include <asm/types.h> is also ok.
>
> i dont think so ... does it really make sense for headers to be hitting
> asm/types.h anyways ? shouldnt they all be going through linux/types.h ?
> checkpatch would certainly warn about it ...

I added following patch which I have pushed out.

Sam