Re: [PATCH] kbuild: auto-convert size types in userspace headers

From: Sam Ravnborg
Date: Tue Dec 30 2008 - 05:42:28 EST


On Mon, Dec 29, 2008 at 03:35:45PM -0800, H. Peter Anvin wrote:
> Sam Ravnborg wrote:
> > On Mon, Dec 29, 2008 at 06:12:33AM -0500, Mike Frysinger wrote:
> >> Rather than constantly fixing up size type breakage in userspace headers,
> >> auto convert the types u_intXX_t, uintXX_t, intXX_t, uXX, and sXX to the
> >> appropriate __uXX or __sXX type.
> >
> > Is this the right thing to do?
> > uintXX_t belongs to a namespace that the kernel should not use.
> >
> > So being restrictive here would be better I think.
>
> That's the whole point right here.
>
> All of these types can be -- and are -- used by the kernel internally,
> but should only be exported as __uXX or __sXX.
>
> This is the auto-conversion idea I brought up earlier.

So the patch from Mike has your "Acked-by"?

Sam
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/