Re: [PATCH 3/3] tracing/ftrace: fix a memory leak in stat tracing

From: Andrew Morton
Date: Tue Jan 06 2009 - 17:53:37 EST


On Tue, 06 Jan 2009 17:33:40 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> static int stat_seq_show(struct seq_file *s, void *v)
> {
> - struct trace_stat_list *l = list_entry(v, struct trace_stat_list, list);
> - return current_tracer.stat_show(s, l->stat);
> + struct trace_stat_list *entry =
> + list_entry(v, struct trace_stat_list, list);
> +
> + return current_tracer.stat_show(s, entry->stat);
> }

Rather than jumping through weird 80-column hoops, one can just do:

struct trace_stat_list *entry;

...

entry = list_entry(v, struct trace_stat_list, list);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/