Re: [PATCH] PCI: add missing KERN_* constants to printks

From: Greg KH
Date: Thu Feb 05 2009 - 12:50:57 EST


On Thu, Feb 05, 2009 at 06:36:37PM +0100, Frank Seidel wrote:
> Frank Seidel wrote:
> > No, its definition in pciehp.h is:
> > ...
>
> P.S.: I also thought about changing it directly inside
> the macro. Would you prefer that?
> I decided against that because those printk-macros often
> still use the loglevel prefix and i didn't want to change
> semantics of the macro (eventhough one would of course
> suspect it to set KERN_DEBUG).

I think that any macro called "dbg" should set the level automatically,
as that is the way that the other macros in the kernel with this name do
things...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/