Re: [PATCH] watchdog: davinci: convert to ioremap() +io[read|write]

[Felipe Balbi]

On Thu, Feb 05, 2009 at 06:26:22PM +0100, Kevin Hilman wrote:
> +       wdt_base = ioremap(res->start, res->end);

second argument should be size right ??

ioremap(res->start, res->end - res->start + 1);

in fact you have a size variable in this driver used for
request_mem_region() just be sure the value is still valid and use it
;-)

> +       if (!wdt_base) {
> +               printk(KERN_ERR MODULE_NAME "failed to map memory region\n");

you have a dev pointer in platform_device would be cool
to use dev_err() here

-- 
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/