Re: [GIT PULL] block bits for 2.6.29-rc5

[Jens Axboe]

On Thu, Feb 19 2009, Andrew Morton wrote:
> On Wed, 18 Feb 2009 15:41:06 +0100
> Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:
> 
> > @@ -3404,6 +3601,24 @@ static int __devinit cciss_init_one(struct pci_dev *pdev,
> >  	int dac, return_code;
> >  	InquiryData_struct *inq_buff = NULL;
> >  
> > +	if (reset_devices) {
> > +		/* Reset the controller with a PCI power-cycle */
> > +		if (cciss_hard_reset_controller(pdev) || cciss_reset_msi(pdev))
> > +			return -ENODEV;
> > +
> > +		/* Some devices (notably the HP Smart Array 5i Controller)
> > +		   need a little pause here */
> > +		schedule_timeout_uninterruptible(30*HZ);
> 
> little!

That does qualify as the understatement of the day :-)

> Perhaps we should do a printk("no, your machine is not dead") here.

Perhaps we should shrink it to something a little more tolerable and put
it in the noop loop instead. 30 seconds is insane...

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/