Re: Fwd: PCF8583 not detected on RiscPC

[Alessandro Zummo]

On Sun, 22 Feb 2009 09:51:50 +0000
Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:

> >   That's very simple, even if acorn is a bit unstructured. You just
> >  need to choice a place under arch/arm that you like
> >  (arch/arm/plat-acorn/ ? ) and place a bit of code called
> >  by an appropriate initcall. 
> 
> Thanks.
> 
> If it is as simple as you are suggesting, why wasn't it done _before_
> breaking the RTC support?

 I guess because who did the modification didn't know
 it was used on acorn and nor did I.

 
> After all, you know damned well that PCF8583 is used on ARM and you
> know the config symbol for the platform, especially as you pointedly
> remove the dependencies on CONFIG_ARCH_RPC from the driver inspite of
 
 ????


> it being full of platform specifics (location of year byte in CMOS
> and the checksum algorithm and checksum location.)
> 
> The only reason I can think is pure and simple spite.

 what??? The driver has been introduced in 9c0c570576d02000063e28faadcce8c07396755d
 without any platform specific ifdef or depend in Kconfig and I never saw it before that
 commit. 

 If any change was ever proposed to make it platform specific (so that it would
 have worked only on a single platform) at any later time I'm pretty sure I
 wouldn't have acked it.

 It was described as:

 "A port of the driver for the pcf8583 i2c rtc controller to the generic RTC
 framework by Alessandro Zummo. Based on
 drivers/acorn/char/{pcf8583.[hc],i2c.c}. Hopefully, acorn can be converted
 too to use this driver in the future."

 and you were on the Cc list. I don't know who converted the acorn platform to
 use it and I can't care less. Who did should have checked the driver 
 for compatibility with his own platform before migrating from the driver under
 drivers/char/ .

 As far as I can see with git log, you applied changes to the driver
 multiple times, without having me in Cc nor G. Liakhovetski (who did the port).

 So, before accusing people, do you homework with a simple
 git log drivers/rtc/rtc-pcf8583.c 

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/