Re: Fwd: PCF8583 not detected on RiscPC

[Russell King - ARM Linux]

On Sun, Feb 22, 2009 at 10:42:05AM +0100, Alessandro Zummo wrote:
> On Sun, 22 Feb 2009 08:28:29 +0000
> Russell King - ARM Linux <linux@xxxxxxxxxxxxxxxx> wrote:
> 
>  
> > So, really, I'm not listening to NACKs from anyone for this.  The only
> > thing I'll listen to is something _constructive_ to make it work again.
> > I'm sure Andrew Morton will back me up on this.
> 
>  You never listened to anyone, as far as I can remember. The constructive
>  part was where I said I'd be happy to give help.

Ditto your listening ability over the fact that the PCF8583 driver is
platform specific.

> > Now, we can either totally reorganize i2c-acorn, but that won't be
> > acceptable for 2.6.29-rc.
> 
>   i2c-acorn is just fine as is, while you might want to change
>  it to a platform driver at a later time.
> 
> 
> > The problem is that this *is* a regression, and therefore must be fixed
> > in 2.6.29-rc.  As I see it, the only sane way to do that is to revert
> > the conversion until a proper fix can be done.
> > 
> > So, please provide constructive suggestions on how to add boardinfo to
> > this in a sane way, or we revert PCF8583 back to something which works.
> 
>   That's very simple, even if acorn is a bit unstructured. You just
>  need to choice a place under arch/arm that you like
>  (arch/arm/plat-acorn/ ? ) and place a bit of code called
>  by an appropriate initcall. 

Thanks.

If it is as simple as you are suggesting, why wasn't it done _before_
breaking the RTC support?

After all, you know damned well that PCF8583 is used on ARM and you
know the config symbol for the platform, especially as you pointedly
remove the dependencies on CONFIG_ARCH_RPC from the driver inspite of
it being full of platform specifics (location of year byte in CMOS
and the checksum algorithm and checksum location.)

The only reason I can think is pure and simple spite.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/