Re: [PATCH 3/3] net-dccp: Suppress warning about large allocationsfrom DCCP

From: Mel Gorman
Date: Tue Jun 23 2009 - 04:48:56 EST

On Mon, Jun 22, 2009 at 04:15:02PM -0700, David Miller wrote:
> From: Mel Gorman <mel@xxxxxxxxx>
> Date: Mon, 22 Jun 2009 16:43:34 +0100
> > The DCCP protocol tries to allocate some large hash tables during
> > initialisation using the largest size possible. This can be larger than
> > what the page allocator can provide so it prints a warning. However, the
> > caller is able to handle the situation so this patch suppresses the warning.
> >
> > Signed-off-by: Mel Gorman <mel@xxxxxxxxx>
> It's probably much more appropriate to make this stuff use
> alloc_large_system_hash(), like TCP does (see net/ipv4/tcp.c
> tcp_init()).

I agree. In another mail I asked why it wasn't used. I guessed it might be
because of the __init tag but nothing stops that being deleted. It should
not take significant effort to make it usable by DCCP.

> All of this complicated DCCP hash table size computation code will
> simply disappear. And it'll fix the warning too :-)

It would be my preferred option :)

Mel Gorman
Part-time Phd Student Linux Technology Center
University of Limerick IBM Dublin Software Lab
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at