Re: merging the per-bdi writeback patchset

From: Andrew Morton
Date: Tue Jun 23 2009 - 04:49:37 EST


On Tue, 23 Jun 2009 10:11:56 +0200 Jens Axboe <jens.axboe@xxxxxxxxxx> wrote:

> Things are looking good for this patchset and it's been in -next for
> almost a week without any reports of problems. So I'd like to merge it
> for 2.6.31 if at all possible. Any objections?

erk. I was rather expecting I'd have time to have a look at it all.

It's unclear to me actually _why_ the performance changes which were
observed have actually occurred. In fact it's a bit unclear (to me)
why the patchset was written and what it sets out to achieve :(

A long time ago the XFS guys (Dave Chinner iirc) said that XFS needs
more than one thread per device to keep the device saturated. Did that
get addressed?

(kthread_run() returns an ERR_PTR() on error, btw - not NULL.)

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/