Re: [PATCH 16/19] drivers/staging: Use PCI_VDEVICE

[Joe Perches]

On Thu, 2009-06-25 at 16:24 +0200, Jiri Slaby wrote:
> > --- a/drivers/staging/vt6655/device_main.c
> > +++ b/drivers/staging/vt6655/device_main.c
> > @@ -344,7 +344,7 @@ static CHIP_INFO chip_info_table[]= {
> >  };
> >  
> >  static struct pci_device_id device_id_table[] __devinitdata = {
> > -{ 0x1106, 0x3253, PCI_ANY_ID, PCI_ANY_ID, 0, 0, (int)&chip_info_table[0]},
> > +{ PCI_VDEVICE(VIA, 0x3253), (int)&chip_info_table[0]},
> 
> Hmm, pointer chopped to 4 bytes on 64-bit. Could you fix that up too?

In addition to original patch

drivers/staging/vt6655: cast pci_device_id driver_data to appropriate type
    
Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>

diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index 7a2377c..a347087 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -344,7 +344,7 @@ static CHIP_INFO chip_info_table[]= {
 };
 
 static struct pci_device_id device_id_table[] __devinitdata = {
-{ PCI_VDEVICE(VIA, 0x3253), (int)&chip_info_table[0]},
+{ PCI_VDEVICE(VIA, 0x3253), (kernel_ulong_t)&chip_info_table[0]},
 { 0, }
 };
 #endif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/