Re: [KVM PATCH v8 1/3] KVM: make io_bus interface more robust

From: Michael S. Tsirkin
Date: Thu Jun 25 2009 - 10:54:25 EST


On Thu, Jun 25, 2009 at 10:22:29AM -0400, Gregory Haskins wrote:
> Gregory Haskins wrote:
> > Today kvm_io_bus_regsiter_dev() returns void and will internally BUG_ON if it
> > fails. We want to create dynamic MMIO/PIO entries driven from userspace later
> > in the series, so we need to enhance the code to be more robust with the
> > following changes:
> >
> > 1) Add a return value to the registration function
> > 2) Fix up all the callsites to check the return code, handle any
> > failures, and percolate the error up to the caller.
> > 3) Add an unregister function that collapses holes in the array

Does not unregister need rcu bus fixes to work?

--
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/