Re: [PATCH] x86: sysctl to allow panic on IOCK NMI error

[Greg KH]

On Thu, Jun 25, 2009 at 10:18:35PM +0200, Ingo Molnar wrote:
> 
> * Greg KH <gregkh@xxxxxxx> wrote:
> 
> > On Thu, Jun 25, 2009 at 11:15:45AM -0700, Eric W. Biederman wrote:
> > > Greg KH <gregkh@xxxxxxx> writes:
> > > 
> > > > From: Kurt Garloff <garloff@xxxxxxx>
> > > >
> > > > This patch introduces a sysctl /proc/sys/kernel/panic_on_io_nmi, which
> > > > defaults to 0 (off).
> > > >
> > > > When enabled, the kernel panics when the kernel receives an NMI caused
> > > > by an IO error.
> > > >
> > > > The IO error triggered NMI indicates a serious system condition, which
> > > > could result in IO data corruption. Rather than contiuing, panicing and
> > > > dumping might be a better choice, so one can figure out what's causing
> > > > the IO error.
> > > >
> > > > This could be especially important to companies running IO intensive
> > > > applications where corruption must be avoided, e.g. a banks databases.
> > > 
> > > Nacked-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>
> > > 
> > > New binary sysctls are not allowed.   Please remove the
> > > sysctl.h and .ctl_name portions.
> > > 
> > > see:
> > > Documentation/sysctl/ctl_unnumbered.txt
> > > Documentation/feature-remove-schedule.txt
> > > 
> > > I have a set of patches that should make this kind of thing
> > > fail to compile for .32.  Hopefully I can get that out in 
> > > the next couple of days.  Making problems like this easier
> > > to spot and deal with.
> > 
> > Oops, ok, will do, sorry about that.  Let me go create a new 
> > patch.
> > 
> > Ingo, do you want an incremental one, or a replacement for the 
> > original?
> 
> Neither - already fixed :)

Wonderful, thanks for doing this.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/