Re: [PATCH] vt: make the default cursor shape configurable

[Pavel Machek]

On Mon 2009-11-09 23:09:44, Daniel Mack wrote:
> On Tue, Nov 10, 2009 at 04:28:03AM +1030, David Newall wrote:
> > Daniel Mack wrote:
> > > And even if the cursor behaviour is changable at runtime, I don't see
> > > why it shouldn't have a selectable compile time default. Which is what
> > > the patch adds.
> > 
> > 
> > It seems like adding cruft to the kernel that is just as effectively
> > available at run-time. Where does it end? Do we eventually add bash to
> > the kernel?
> 
> One more thing:
> 
> Clemens' last patch didn't add anything to the kernel's binary size.
> It didn't slow down anything either, as there is no run-time condition
> evaluation. It just makes something configurable which was hard
> coded before. So where's the cruft?

The number of configs to test just got bigger. 100% bigger in
fact. Every single developer will have to answer 'do you want blinking
cursor?' when your patch is merged.

config options _are_ expensive.

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/