Re: [PATCH] MIPS: cleanup switches with cases that can be merged

From: David Daney
Date: Tue Jan 19 2010 - 21:08:40 EST

Roel Kluin wrote:
I did a search for switch statements with cases that can be merged, but maybe
some were not intended?
In these cases the same code was executed.

Signed-off-by: Roel Kluin <roel.kluin@xxxxxxxxx>
arch/mips/include/asm/octeon/octeon-feature.h | 8 ++------
arch/mips/kernel/cpu-probe.c | 3 ---
arch/mips/math-emu/ieee754dp.c | 1 -
arch/mips/math-emu/ieee754sp.c | 1 -
arch/mips/pci/pci-octeon.c | 6 ++----
arch/mips/powertv/asic/asic_devices.c | 4 ----
arch/mips/sgi-ip32/ip32-irq.c | 9 +--------
7 files changed, 5 insertions(+), 27 deletions(-)

This patch should be split up.

Octeon, PowerTV, and IP32 are all different architectures. They should be in their own patches.

The two math-emu parts could probably go together.

cpu-probe seems like its own thing.

This brings us to the larger question: This is just code churn. Is it even worthwhile?

David Daney

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at