Re: [PATCH] MIPS: cleanup switches with cases that can be merged

From: Alexander Clouter
Date: Wed Jan 20 2010 - 07:10:23 EST

In gmane.linux.ports.mips.general David Daney <ddaney@xxxxxxxxxxxxxxxxxx> wrote:
> [snipped]
> This brings us to the larger question: This is just code churn. Is it
> even worthwhile?
Anything which reduces the line count and remove duplication whilst
sticking to CodingStyle I would always argue for, but "who am I" :)

It at a glance, this type of code churn, shows there are no differences
between two classes of <whatever> and the effect is it makes the chunk
of code a mental NOOP for the person reading the code. :)

To me this is a natural extension of running with Chapter 14 of
CodingStyle where you kmalloc using 'sizeof(*p)' rather than
'sizeof(struct *foo)' so reducing the chance of errors later on.

Just my thoughts.


Alexander Clouter
.sigmonster says: Snoopy: No problem is so big that it can't be run away from.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at