Re: [PATCHv2 03/11] mxc: Fix Drive Strength Field in the IOMUX controller

[Eric Miao]

On Tue, Feb 2, 2010 at 9:16 PM, Amit Kucheria
<amit.kucheria@xxxxxxxxxxxxx> wrote:
> i.MX51 defines 4 values:
>
> 00: Low Drive Strength
> 01: Medium Drive Strength
> 10: High Drive Strength
> 11: Max Drive Strength
>
> Signed-off-by: Amit Kucheria <amit.kucheria@xxxxxxxxxxxxx>
> ---
> Âarch/arm/plat-mxc/include/mach/iomux-v3.h | Â Â8 +++++---
> Â1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/include/mach/iomux-v3.h b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> index 1deda01..f2f73d3 100644
> --- a/arch/arm/plat-mxc/include/mach/iomux-v3.h
> +++ b/arch/arm/plat-mxc/include/mach/iomux-v3.h
> @@ -81,11 +81,13 @@ struct pad_desc {
>
> Â#define PAD_CTL_ODE Â Â Â Â Â Â Â Â Â Â(1 << 3)
>
> -#define PAD_CTL_DSE_STANDARD Â Â Â Â Â (0 << 1)
> -#define PAD_CTL_DSE_HIGH Â Â Â Â Â Â Â (1 << 1)
> -#define PAD_CTL_DSE_MAX Â Â Â Â Â Â Â Â Â Â Â Â(2 << 1)
> +#define PAD_CTL_DSE_LOW Â Â Â Â Â Â Â Â Â Â Â Â(0 << 1)
> +#define PAD_CTL_DSE_MED Â Â Â Â Â Â Â Â Â Â Â Â(1 << 1)
> +#define PAD_CTL_DSE_HIGH Â Â Â Â Â Â Â (2 << 1)
> +#define PAD_CTL_DSE_MAX Â Â Â Â Â Â Â Â Â Â Â Â(3 << 1)
>

I'm seeing some changes in recent kernel with introduction of PAD_CTL_DRV_*,
which also affects mx3, think it's a tough problem to keep backward
compatibility
now, one way out is to introduce maybe PAD_CTL_DRV_EXTREME specifically
for imx51.

> Â#define PAD_CTL_SRE_FAST Â Â Â Â Â Â Â (1 << 0)
> +#define PAD_CTL_SRE_SLOW Â Â Â Â Â Â Â (0 << 0)
>
> Â/*
> Â* setups a single pad in the iomuxer
> --
> 1.6.3.3
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/