Re: should new kfifo implementation really be exporting that much?

[Tilman Schmidt]

Am 14.03.2010 15:57 schrieb Robert P. J. Day:
>   as a short followup, kfifo.h strongly implies that a lot of the
> above shouldn't be exported:
> 
> ...
> /*
>  * __kfifo_in_... internal functions for put date into the fifo
>  * do not call it directly, use kfifo_in_rec() instead
>  */
> ...
> 
>   anyway, you get the idea.  it would seem that a lot of those EXPORTs
> should be removed, no?

If you look at kfifo_in_rec(), it's a static inline void function
defined in kfifo.h and which calls __kfifo_in_generic() or
__kfifo_in_rec(). I don't think you'll be able to make that work
without exporting those functions.

HTH
T.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/