Re: [patch] x86: fix fake apicid to node mapping for numaemulation

From: David Rientjes
Date: Thu May 06 2010 - 05:24:24 EST


On Thu, 6 May 2010, Ingo Molnar wrote:

> > apicids must be mapped to the lowest node ids to maintain generic kernel use
> > of functions such as cpu_to_node() that determine device affinity.
> >
> > Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> > ---
> > Third resend of the same patch.
> >
> > arch/x86/mm/srat_64.c | 3 ++-
> > 1 files changed, 2 insertions(+), 1 deletions(-)
>
> There's no info in the changelog about what negative effects this bug had when
> it was found, on what hardware it occured, and what the general urgency of the
> patch is.
>

Ah, true. Given the relative obscurity of using NUMA emulation to being
with, it would probably benefit from being even more verbose as well.
I'll rewrite the changelog and reply to this message with it.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/