Re: [PATCH] fix a code style in drivers/char/virtio_console.c

From: Amit Shah
Date: Tue May 18 2010 - 01:21:33 EST

Next message: Steven Liu: "[PATCH] random: Check kmalloc return value and give the failed message"
Previous message: Stephen Rothwell: "linux-next: manual merge of the drbd tree with the block tree"
In reply to: Steven Liu: "[PATCH] fix a code style in drivers/char/virtio_console.c"
Next in thread: Steven Liu: "Re: [PATCH] fix a code style in drivers/char/virtio_console.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On (Tue) May 18 2010 [13:17:22], Steven Liu wrote:
> fix a code style in drivers/char/virtio_console.c
>
> Signed-off-by: Liu Qi <lingjiujianke@xxxxxxxxx>

NACK.

This style is deliberate and follows Rusty's style: if we end up using
'err' uninitialised in some code path, it can get flagged by source
checkers.

Amit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

Next message: Steven Liu: "[PATCH] random: Check kmalloc return value and give the failed message"
Previous message: Stephen Rothwell: "linux-next: manual merge of the drbd tree with the block tree"
In reply to: Steven Liu: "[PATCH] fix a code style in drivers/char/virtio_console.c"
Next in thread: Steven Liu: "Re: [PATCH] fix a code style in drivers/char/virtio_console.c"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]