Re: [PATCH] fix a code style in drivers/char/virtio_console.c

[Steven Liu]

Hi, Amit,

    if 'err' initialised in this path, it needn't do err = -ENOMEM
after,isn't it?



Best regards


2010/5/18 Amit Shah <amit.shah@xxxxxxxxxx>:
> On (Tue) May 18 2010 [13:17:22], Steven Liu wrote:
>> fix a code style in drivers/char/virtio_console.c
>>
>> Signed-off-by: Liu Qi <lingjiujianke@xxxxxxxxx>
>
> NACK.
>
> This style is deliberate and follows Rusty's style: if we end up using
> 'err' uninitialised in some code path, it can get flagged by source
> checkers.
>
>                Amit
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/