[PATCH 2/4] mfd: tps6507x - fix incorrect kfree(i2c) in i2c_driverprobe callback handler

From: Axel Lin
Date: Mon Aug 09 2010 - 02:48:07 EST


The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
---
drivers/mfd/tps6507x.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/tps6507x.c b/drivers/mfd/tps6507x.c
index d859dff..fc01976 100644
--- a/drivers/mfd/tps6507x.c
+++ b/drivers/mfd/tps6507x.c
@@ -89,10 +89,8 @@ static int tps6507x_i2c_probe(struct i2c_client *i2c,
int ret = 0;

tps6507x = kzalloc(sizeof(struct tps6507x_dev), GFP_KERNEL);
- if (tps6507x == NULL) {
- kfree(i2c);
+ if (tps6507x == NULL)
return -ENOMEM;
- }

i2c_set_clientdata(i2c, tps6507x);
tps6507x->dev = &i2c->dev;
--
1.5.4.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/