[PATCH 3/4] mfd: wm831x-core - fix incorrect kfree(i2c) ini2c_driver probe callback handler

From: Axel Lin
Date: Mon Aug 09 2010 - 02:49:35 EST


The i2c_client received in probe() should not be kfree()'d.

Signed-off-by: Axel Lin <axel.lin@xxxxxxxxx>
---
drivers/mfd/wm831x-core.c | 4 +---
1 files changed, 1 insertions(+), 3 deletions(-)

diff --git a/drivers/mfd/wm831x-core.c b/drivers/mfd/wm831x-core.c
index cb94e7e..1e7aaaf 100644
--- a/drivers/mfd/wm831x-core.c
+++ b/drivers/mfd/wm831x-core.c
@@ -1757,10 +1757,8 @@ static int wm831x_i2c_probe(struct i2c_client *i2c,
struct wm831x *wm831x;

wm831x = kzalloc(sizeof(struct wm831x), GFP_KERNEL);
- if (wm831x == NULL) {
- kfree(i2c);
+ if (wm831x == NULL)
return -ENOMEM;
- }

i2c_set_clientdata(i2c, wm831x);
wm831x->dev = &i2c->dev;
--
1.5.4.3



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/