Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to2.6.35

[Greg KH]

On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> Hi Greg,
> 
> > Do they all have to be ioctls?  What exactly are they doing?
> I think using ioctl is common for this patch.

"Common" is not ok, right?

> Do you think that using ioctl is NOT appropriate for this patch?

Yes.

> Let me know your intension in more detail.

Please express yours.  Why do you feel you need these to be ioctls?
What exactly are they doing?  Where is the documentation for them all?

> > And are they 32/64bit safe?
> Only 32bit support.

That's an obvious problem that needs to be resolved, right?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/