RE: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to2.6.35
From: Wang, Qi
Date: Wed Aug 11 2010 - 21:13:59 EST
> -----Original Message-----
> From: Greg KH [mailto:gregkh@xxxxxxx]
> Sent: Wednesday, August 11, 2010 11:15 PM
> To: Masayuki Ohtake
> Cc: meego-dev@xxxxxxxxx; LKML; Wang, Qi; Wang, Yong Y; Khor, Andrew
> Chih Howe; arjan@xxxxxxxxxxxxxxx
> Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to
> 2.6.35
>
> On Wed, Aug 11, 2010 at 04:29:25PM +0900, Masayuki Ohtake wrote:
> > Hi Greg,
> >
> > > Do they all have to be ioctls? What exactly are they doing?
> > I think using ioctl is common for this patch.
>
> "Common" is not ok, right?
>
> > Do you think that using ioctl is NOT appropriate for this patch?
>
> Yes.
>
> > Let me know your intension in more detail.
>
> Please express yours. Why do you feel you need these to be ioctls?
> What exactly are they doing? Where is the documentation for them all?
>
> > > And are they 32/64bit safe?
> > Only 32bit support.
>
> That's an obvious problem that needs to be resolved, right?
The Tunnelcreak processor (A kind of Atom-based processor) only supports 32b, so PCH drivers only support 32b.
They can make it 32/64 compatible, but it's difficult to test them, because there're no 64b Atom-based platform have those PCH devices.
Best Regards,
QI.
>
> thanks,
>
> greg k-h
¢éì®&Þ~º&¶¬+-±éÝ¥w®Ë±Êâmébìdz¹Þ)í
æèw*jg¬±¨¶Ýj/êäz¹Þà2Þ¨èÚ&¢)ß«a¶Úþø®G«éh®æj:+v¨wèÙ>W±êÞiÛaxPjØm¶ÿÃ-»+ùd_