Re: [60/67] mtd: gen_nand: fix support for multiple chips

[Marek Vasut]

Dne Ät 12. srpna 2010 02:06:15 Greg KH napsal(a):
> 2.6.35-stable review patch.  If anyone has any objections, please let us
> know.

It's going to break plat-qong, apparently the code there is incorrect and 
depends on this bug, I'll send a patch for it in a bit.
> 
> ------------------
> 
> From: Marek Vasut <marek.vasut@xxxxxxxxx>
> 
> commit 81cbb0b17796d81cbd92defe113cf2a7c7a21fbb upstream.
> 
> This patch corrects a problem where gen_nand driver assumed there can be
> only one chip and ignored the pdata->chip.nr_chips value.
> 
> Signed-off-by: Marek Vasut <marek.vasut@xxxxxxxxx>
> Signed-off-by: Artem Bityutskiy <Artem.Bityutskiy@xxxxxxxxx>
> Signed-off-by: David Woodhouse <David.Woodhouse@xxxxxxxxx>
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxx>
> 
> ---
>  drivers/mtd/nand/plat_nand.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/mtd/nand/plat_nand.c
> +++ b/drivers/mtd/nand/plat_nand.c
> @@ -91,7 +91,7 @@ static int __devinit plat_nand_probe(str
>  	}
> 
>  	/* Scan to find existance of the device */
> -	if (nand_scan(&data->mtd, 1)) {
> +	if (nand_scan(&data->mtd, pdata->chip.nr_chips)) {
>  		err = -ENXIO;
>  		goto out;
>  	}
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/