Re: [PATCH v2] MD: raid, fix BUG caused by flags handling

[Jeff Moyer]

Jiri Slaby <jslaby@xxxxxxx> writes:

> Commit 74450be1 (block: unify flags for struct bio and struct request)
> added direct test of flags in the & form:
>   const bool do_sync = (bio->bi_rw & REQ_SYNC);
> But this doesn't fit into bool with my compiler (gcc 4.5). So change
> the type to ulong to avoid the bug.

At first I wondered why you didn't use the !! trick, but after looking
at the code, I see that the result is |'d into bi_rw.

Looks good.  Sounds like it might have been a real bear to track down.

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/