Re: [PATCH v2] SCSI: fix bio.bi_rw handling

From: Jeff Moyer
Date: Thu Aug 12 2010 - 09:31:04 EST


Jiri Slaby <jslaby@xxxxxxx> writes:

> Return of the bi_rw tests is no longer bool after commit 74450be1. So
> testing against constants doesn't make sense anymore. Fix this bug in
> osd_req_read by removing "== 1" in test.
>
> This is not a problem now, where REQ_WRITE is 1, but this can change
> in the future and we don't want to rely on that.
>
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxx>
> Cc: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Jeff Moyer <jmoyer@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/