Re: [PATCH v2] SCSI: fix bio.bi_rw handling

[Christoph Hellwig]

On Thu, Aug 12, 2010 at 02:31:05PM +0200, Jiri Slaby wrote:
> Return of the bi_rw tests is no longer bool after commit 74450be1. So
> testing against constants doesn't make sense anymore. Fix this bug in
> osd_req_read by removing "== 1" in test.
> 
> This is not a problem now, where REQ_WRITE is 1, but this can change
> in the future and we don't want to rely on that.

And it's much cleaner anyway.  Note that I think we particularly need
the WARN_ON anyway.


Reviewed-by: Christoph Hellwig <hch@xxxxxx>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/