Re: [PATCH 26/30] ext4: do not send discards as barriers

From: Tejun Heo
Date: Wed Aug 25 2010 - 12:03:55 EST


On 08/25/2010 06:00 PM, Christoph Hellwig wrote:
> On Wed, Aug 25, 2010 at 05:58:42PM +0200, Christoph Hellwig wrote:
>> On Wed, Aug 25, 2010 at 05:47:43PM +0200, Tejun Heo wrote:
>>> From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
>>>
>>> ext4 already uses synchronous discards, no need to add I/O barriers.
>>
>> This needs the patch that Jan sent in reply to my initial version merged
>> into it.
>
> Actually the jbd2 patch needs it merged, but the point still stands.

Yeah, wasn't sure about that one. Has anyone tested it? I'll be
happy to merge it but I have no idea whether it's correct or not and
Jan didn't seem to have tested it so... Jan, shall I merge the patch?

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/