Re: [PATCH] drivers/hwmon: Use pr_fmt and pr_<level>

[Joe Perches]

On Tue, 2010-10-19 at 20:29 -0700, Guenter Roeck wrote:
> On Tue, Oct 19, 2010 at 07:13:40PM -0400, Joe Perches wrote:
> > Convert printks to pr_<level>
> > Coalesce long formats
> > Removed prefixes from formats
> > Added #define pr_fmt KBUILD_MODNAME ": " fmt
> > Standardized abitguru messages for reporting and finding MAINTAINER
> > Compiled x86 allyesconfig only.
> > I inspected "strings drivers/hwmon/built-in.o",
> > but it's otherwise untested.
> > Signed-off-by: Joe Perches <joe@xxxxxxxxxxx>
> There are several lines longer than 80 characters.
> Does this rule no longer apply ?

80 columns isn't checked for printk format strings.

A kernel general preference may be to keep formats as
a single string without line breaks so that grep works
better.

> Oddly enough, there are only four checkpatch warnings about long lines,
> even though there are many more.

The version I use doesn't show any warnings.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/