Re: [PATCH] [USB] Allow retrieval of the Caching mode page

[Luben Tuikov]

--- On Thu, 10/21/10, Matthew Dharm <mdharm-kernel@xxxxxxxxxxxxxxxxxx> wrote:
> If you remove this, there are several devices which will
> stop working.
> They will simply go out-to-lunch when the sd_mod driver
> sends a request for
> Mode Page 8.

That's true. But it seems unfair to punish good devices which do support
the Caching mode page.

sd_revalidate_disk() calls in succession sd_read_write_protect_flag(),
sd_read_cache_type() and sd_read_app_tag_own().  The first, asks for all
pages by setting the page code to 0x3F. Surely if the device server
supports the Caching mode page, it will be returned. The second call, asks
only for the Caching mode page, and here is where some (few?) broken
devices fail.

If the skip_ms_page_8 is set, why not request all pages, and see if the
Caching mode page is part of the parameter data.

Anyone willing to code that up in sd_read_cache_type()?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/