Re: [PATCH] percpu_counter : add percpu_counter_add_fast()

[Eric Dumazet]

Le jeudi 21 octobre 2010 Ã 17:45 -0700, Andrew Morton a Ãcrit :

> this_cpu_add_return() isn't really needed in this application.
> 
> {
> 	this_cpu_add(*fbc->counters, amount);
> 	if (unlikely(abs(this_cpu_read(*fbc->counters)) > fbc->batch))
> 		out_of_line_stuff();
> }	
> 
> will work just fine.				

Hmm, you cannot do this on 32bit machines because "amount" is 64bit
wide.

Switching counters to s64 is not an option (makes summation racy, and
memory use bigger)



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/