Re: [RFC/PATCH] usb: Add streams support to epautoconf.

[Greg KH]

On Sun, Nov 14, 2010 at 08:23:20AM +0200, Maya Erez wrote:
> +	/* Get the number of required streams from the EP companion
> +	 * descriptor and see if the EP matches it
> +	 */

Close, but this isn't the proper format for multi-line comments in the
kernel.  Please fix this.

> +	if (USB_ENDPOINT_XFER_BULK == type) {

Ick, no, don't do comparisons like this.  The compiler will let you know
if you acidentally get it wrong with only one '=' character, don't do
things "backward" like this just to work around stupid compilers.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/