Re: [RFC/PATCH] usb: Add streams support to epautoconf.

[Felipe Balbi]

Hi,

On Sun, 2010-11-14 at 10:29 -0800, Greg KH wrote:
> > +	if (USB_ENDPOINT_XFER_BULK == type) {
> 
> Ick, no, don't do comparisons like this.  The compiler will let you know
> if you acidentally get it wrong with only one '=' character, don't do
> things "backward" like this just to work around stupid compilers.

we actually have helpers for this and usb_endpoint_xfer_bulk(desc)
would do it.

-- 
balbi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/