RE: [PATCH] mfd: tps6586x: Remove device ID check

From: Andrew Chew
Date: Thu Dec 02 2010 - 16:02:17 EST


> -----Original Message-----
> From: Stephen Warren [mailto:swarren@xxxxxxxxxx]
> Sent: Thursday, December 02, 2010 10:33 AM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: sameo@xxxxxxxxxxxxxxx; Andrew Chew; olofj@xxxxxxxxxxxx;
> Stephen Warren
> Subject: [PATCH] mfd: tps6586x: Remove device ID check
>
> ... and convert it to a dev_info print at probe time.
>
> There are many variants of this chip with different values of
> VERSIONCRC.
> The set of values is large, and not useful to enumerate. All are SW
> compatible. The difference lies in default settings of the
> various power
> rails, and other similar differences. The driver, or clients of the
> driver, shouldn't be affected by this, since all rails should be
> programmed into the desired state in all cases for correct operation.
>
> Derived-from-code-by: Andrew Chew <achew@xxxxxxxxxx>
> Signed-off-by: Stephen Warren <swarren@xxxxxxxxxx>

LGTM.

Acked by: Andrew Chew <achew@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/