Re: [RFC/PATCH v2] usb: Add streams support to epautoconf.

[Greg KH]

On Mon, Dec 20, 2010 at 11:33:44AM -0800, merez@xxxxxxxxxxxxxx wrote:
> > On Thu, Dec 16, 2010 at 10:15AM, Greg KH wrote:
> > What do you exactly mean by "proprietary search algorithm"?
> Our implementation for finding an EP with the required number of streams
> may not fit the needs and platform definitions of all controllers.  For
> example, having the minimum number of streams as a parameter will allow
> controllers to compromise on the number of required streams in case there
> is no EP that answers their first request.
> At the beginning of usb_ep_autoconfig we could see many if statements for
> finding the fitting EP for several controllers (for example
> gadget_is_net2280). The new gadget op will prevent having additional if
> statements in the usb_ep_autoconfig in case a different search is needed. 

Ok, but please note the word of "proprietary" usually means something
else when talking about kernel code (i.e. licensing issues.)

I'll be glad to take this type of patch when you also provide a patch
that uses the callback, but not before then.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/