Re: [patch -next] power/gpio-charger: check for kzalloc() failure
From: Lars-Peter Clausen
Date: Mon Dec 20 2010 - 15:05:16 EST
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 12/20/2010 02:08 PM, Dan Carpenter wrote:
> Return -ENOMEM if kzalloc() fails.
>
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
>
> diff --git a/drivers/power/gpio-charger.c b/drivers/power/gpio-charger.c
> index fccbe99..06a74f0 100644
> --- a/drivers/power/gpio-charger.c
> +++ b/drivers/power/gpio-charger.c
> @@ -87,6 +87,8 @@ static int __devinit gpio_charger_probe(struct platform_device *pdev)
> }
>
> gpio_charger = kzalloc(sizeof(*gpio_charger), GFP_KERNEL);
> + if (!gpio_charger)
> + return -ENOMEM;
>
> charger = &gpio_charger->charger;
>
Hi
This is now the 4th patch or so fixing this issue. I send the first one[1], together
with some other fixes[2][3], a month ago.
Anton could you please pick them up?
Thanks
- - Lars
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1011.2/02029.html
[2] http://lkml.indiana.edu/hypermail/linux/kernel/1011.2/02028.html
[3] http://lkml.indiana.edu/hypermail/linux/kernel/1011.2/02030.html
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk0PtuYACgkQBX4mSR26RiOCRQCfdKUdpAjX2GxAJuGVekZDiyjx
j3IAnRCS562ud3Ali/B5V1gWNeBHcxNj
=M4Vg
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/