Re: [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMAemulation
From: Yinghai Lu
Date: Thu Jan 06 2011 - 16:26:41 EST
On 01/06/2011 12:39 PM, David Rientjes wrote:
> On Thu, 30 Dec 2010, David Rientjes wrote:
>
>> "x86, numa: Fake node-to-cpumask for NUMA emulation" broke the build when
>> CONFIG_DEBUG_PER_CPU_MAPS is set and CONFIG_NUMA_EMU is not. This is
>> because it is possible to map a cpu to multiple nodes when NUMA emulation
>> is used; the patch required a physical node address table to find those
>> nodes that was only available when CONFIG_NUMA_EMU was enabled.
>>
>> This extracts the common debug functionality to its own function for
>> CONFIG_DEBUG_PER_CPU_MAPS and uses it regardless of whether
>> CONFIG_NUMA_EMU is set or not.
>>
>> NUMA emulation will now iterate over the set of possible nodes for each
>> cpu and call the new debug function whereas only the cpu's node will be
>> used without NUMA emulation enabled.
>>
>> Reported-by: Ingo Molnar <mingo@xxxxxxx>
>> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
>
> Ingo, do you know what the status of this fix is? It's required for
> x86/numa to build and I'd hate to see all of this fixes miss .38 because
> of this failure.
If x86/numa would not be pushed to Linus. x86/apic-cleanups should be pushed at first.
or Thomas will take care of it?
Thanks
Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/