Re: [patch] x86, numa: Fix CONFIG_DEBUG_PER_CPU_MAPS without NUMAemulation

From: David Rientjes
Date: Thu Jan 06 2011 - 18:58:24 EST


On Thu, 6 Jan 2011, Yinghai Lu wrote:

> >> "x86, numa: Fake node-to-cpumask for NUMA emulation" broke the build when
> >> CONFIG_DEBUG_PER_CPU_MAPS is set and CONFIG_NUMA_EMU is not. This is
> >> because it is possible to map a cpu to multiple nodes when NUMA emulation
> >> is used; the patch required a physical node address table to find those
> >> nodes that was only available when CONFIG_NUMA_EMU was enabled.
> >>
> >> This extracts the common debug functionality to its own function for
> >> CONFIG_DEBUG_PER_CPU_MAPS and uses it regardless of whether
> >> CONFIG_NUMA_EMU is set or not.
> >>
> >> NUMA emulation will now iterate over the set of possible nodes for each
> >> cpu and call the new debug function whereas only the cpu's node will be
> >> used without NUMA emulation enabled.
> >>
> >> Reported-by: Ingo Molnar <mingo@xxxxxxx>
> >> Signed-off-by: David Rientjes <rientjes@xxxxxxxxxx>
> >
> > Ingo, do you know what the status of this fix is? It's required for
> > x86/numa to build and I'd hate to see all of this fixes miss .38 because
> > of this failure.
>
> If x86/numa would not be pushed to Linus. x86/apic-cleanups should be pushed at first.
> or Thomas will take care of it?
>

x86/apic-cleanups was merged in x86/numa, so it can be pushed regardless
of whether x86/numa will make it upstream in this cycle or not (Peter said
it was on target for .38, but this patch has been dormant for a couple
weeks).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/