Re: [PATCH 2/4] x86, numa: Do not adjust start/end forearly_node_mem()

[Tejun Heo]

Hello,

On Sat, Feb 19, 2011 at 08:17:11PM -0800, Yinghai Lu wrote:
> > The old code guarantees that the range is from a single zone, and even
> > though memblock may be top -> down, it seems like there would be
> > configurations where this would still be an issue (perhaps simulating it
> > with numa=fake for testing?) if it crosses the boundary.
> 
> memblock_x86_find_in_range_node() will go over with early_node_map[].
> so it will always can get right on node allocation.

I think always doing top-down allocation should be enough as long as
there's no highmem, which we don't have on 64bit.  That said, the
patch description should note the behavior difference.  Yinghai, care
to add a bit more detail to the patch description?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/