Re: [PATCH 3/4] x86, numa: cleanup x86_acpi_numa_init()

[Tejun Heo]

On Sat, Feb 19, 2011 at 08:03:48PM -0800, David Rientjes wrote:
> On Fri, 18 Feb 2011, Yinghai Lu wrote:
> > make it more readable. put valid checking together.
> > 
> > Also restore old acpi_numa_init(). we don't need to touch it
> > because already have x86 own wrapper.
> > 
> > We can limit change to x86 code only.
> > 
> > Signed-off-by: Yinghai Lu <yinghai@xxxxxxxxxx>
> 
> Acked-by: David Rientjes <rientjes@xxxxxxxxxx>

I'm not taking this one.  It's pointless and to me it seems worse.
Why does the function return the count?  What difference do the counts
of 5 and 10 make to the caller?  All it can indicate is failure or
success and 0 and -errno are much better return values for that.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/