Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead oftask_struct

From: Stephen Wilson
Date: Wed Mar 09 2011 - 09:16:19 EST

Next message: saeed bishara: "Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and addsupport for second LED This is a patch to the sheevaplug-setup.c file thatfixes the color name of the existing health LED. That LED gpio 49 is greenwhen off and blue when on. The pat"
Previous message: Sergei Shtylyov: "Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and addsupport for second LED This is a patch to the sheevaplug-setup.c file thatfixes the color name of the existing health LED. That LED gpio 49 is greenwhen off and blue when on. The patch also adds support for the second LEDthat is green when off and red when on. Signed-off-by: Robin Becker <robin@reportlab.com>"
In reply to: Michel Lespinasse: "Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead of task_struct"
Next in thread: Andi Kleen: "Re: [PATCH 0/5] make *_gate_vma accept mm_struct instead oftask_struct"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On Wed, Mar 09, 2011 at 05:09:09AM -0800, Michel Lespinasse wrote:
> On Tue, Mar 8, 2011 at 4:31 PM, Stephen Wilson <wilsons@xxxxxxxx> wrote:
> > Morally, the question of whether an address lies in a gate vma should be asked
> > with respect to an mm, not a particular task.
> >
> > Practically, dropping the dependency on task_struct will help make current and
> > future operations on mm's more flexible and convenient. In particular, it
> > allows some code paths to avoid the need to hold task_lock.
>
> Reviewed-by: Michel Lespinasse <walken@xxxxxxxxxx>
>
> May I suggest ia32_compat instead of just compat for the flag name ?

Yes, sounds good to me. Will change in the next iteration.

Thanks for the review!

> --
> Michel "Walken" Lespinasse
> A program is never fully debugged until the last user dies.

--
steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/