Re: [PATCH] stable: sheevaplug-setup.c fix LED color name and addsupport for second LED This is a patch to the sheevaplug-setup.c file thatfixes the color name of the existing health LED. That LED gpio 49 is greenwhen off and blue when on. The pat

From: saeed bishara
Date: Wed Mar 09 2011 - 09:16:47 EST


On Wed, Mar 9, 2011 at 3:27 PM, Robin Becker <replabrobin@xxxxxxxxx> wrote:
> From: replabrobin <robin@xxxxxxxxxxxxx>
please use short subject for this commit, and move the description
into the commit description section
aslo, I would split this to two patches, one fixes the LED color name,
the second for adding the new LED.

> Âstatic unsigned int sheevaplug_mpp_config[] __initdata = {
> Â Â Â ÂMPP29_GPIO, Â Â /* USB Power Enable */
> - Â Â Â MPP49_GPIO, Â Â /* LED */
> + Â Â Â MPP46_GPIO, Â Â /* RED LED */
> + Â Â Â MPP49_GPIO, Â Â /* BLUE LED */
> Â Â Â Â0
> Â};
>
> Âstatic unsigned int sheeva_esata_mpp_config[] __initdata = {
> Â Â Â ÂMPP29_GPIO, Â Â /* USB Power Enable */
> Â Â Â ÂMPP44_GPIO, Â Â /* SD Write Protect */
> + Â Â Â MPP46_GPIO, Â Â /* RED LED */
> Â Â Â ÂMPP47_GPIO, Â Â /* SD Card Detect */
> Â Â Â ÂMPP49_GPIO, Â Â /* LED Green */
please fix the comment as well
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/