Re: [PATCH 2/2] eeepc-wmi: Add support for T101MT Home/Express Gatekey

[Dmitry Torokhov]

On Fri, Mar 25, 2011 at 11:28:50AM -0500, Seth Forshee wrote:
> On Fri, Mar 25, 2011 at 09:14:05AM -0700, Dmitry Torokhov wrote:
> > > If you keep a keyboard key pressed, you want multiple events, not one right ?
> > > I think it's important not to loose informations. If someone keep this
> > > key pressed more than 1.5 second, I think it's good idea to send
> > > multiple KEY_PROG2.
> > 
> > You can have input autorepeat facilities do that for you. If you want to
> > do this yourself then the proper value for repeated events is _2_, not
> > 1, or they will be dropped as duplicates.
> > 
> > > 
> > > About KEY_HOME press / release, and filtering KEY_HOME after
> > > KEY_PROG2, I'm not sure. So if you really want it, and nobody
> > > complains, I'll be happy to accept your patch.
> > > 
> > > > And back to the question of KEY_HOME -- that's not really what you want,
> > > > is it? As in "move cursor to start of line"?
> > > 
> > > Ho .. right, that's what mean KEY_HOME :/. So no, I don't want that...
> > > What about:
> > > - KEY_CYCLEWINDOWS
> > > - KEY_COMPUTER
> > > - KEY_HOMEPAGE
> > > - KEY_DASHBOARD
> > > 
> > > I think KEY_HOMEPAGE is the best choice.
> > 
> > No, KEY_HOMEPAGE should cause your browser to go to your home page. What
> > you want is either:
> > 
> > #define KEY_CONFIG         171     /* AL Consumer Control Configuration */
> > #define KEY_DASHBOARD      204     /* AL Dashboard */
> > 
> > ("AL" stands for "Application Launcher", "AC" for 'Application Control",
> > matched loosely to HUT tables).
> 
> Dmitry,
> 
> I didn't see you responses before my last response, so you can ignore
> it. Let me make sure I understand correctly. For reference, the button
> in question sends an 0xe4 scancode on press, repeated 0xea scancodes on
> hold, and 0xe5 on release.
> 
> So, would the following make sense (KEY_TBD is may abbreviation for "key
> to be determinded"):
> 
>  - On press (0xe4), send KEY_TBD, value = 1
>  - On hold (0xea), send KEY_TBD, value = 2
>  - On release (0xe5), send KEY_TBD, value = 0

Yes.

> 
> Also, is KEY_CYCLEWINDOWS intended to imply screen rotation, or
> something else?

Hmm, it was added way before my time. I'd expect it to have an action
similar to Alt-Tab. Vojtech, do you still remember what it was supposed
to be?

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/